Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix install script on all platforms #1583

Merged
merged 4 commits into from Jan 29, 2020
Merged

Fix install script on all platforms #1583

merged 4 commits into from Jan 29, 2020

Conversation

tadaskay
Copy link
Member

@tadaskay tadaskay commented Jan 29, 2020

Need to merge it before merging the installation test

Without this, on docker (ubuntu:18.04 image) the following occurs:
E: Unable to locate package linux-headers-4.19.76-linuxkit
E: Couldn't find any package by glob 'linux-headers-4.19.76-linuxkit'
E: Couldn't find any package by regex 'linux-headers-4.19.76-linuxkit'

However, it appears that wireguard installs just fine and downloads/builds for:
linux-headers-4.15.0-76-generic
After which, adding/removing wg interface works without errors
It appears that wireguard installs and builds kernel module just fine without those extra libs.
@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

Merging #1583 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1583      +/-   ##
==========================================
+ Coverage   47.39%   47.41%   +0.01%     
==========================================
  Files         291      291              
  Lines       11524    11524              
==========================================
+ Hits         5462     5464       +2     
+ Misses       5669     5668       -1     
+ Partials      393      392       -1
Impacted Files Coverage Δ
tequilapi/sse/sse.go 71.11% <0%> (ø) ⬆️
core/discovery/discovery.go 66.38% <0%> (+0.84%) ⬆️
core/promise/methods/noop/dialog_mock.go 71.87% <0%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0c45ddb...e8e2609. Read the comment docs.

Previously, it would not always download matching headers for the current kernel.
Because raspberrypi-linux-headers may be pointing to a newer version.
rpi-source tool downloads headers for the current version making it unnecessary to upgrade the kernel.
@tadaskay tadaskay merged commit 699663b into master Jan 29, 2020
@tadaskay tadaskay deleted the 1545-fix-install-sh branch January 29, 2020 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants