Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobile bindings #1589

Merged
merged 1 commit into from Jan 29, 2020
Merged

Fix mobile bindings #1589

merged 1 commit into from Jan 29, 2020

Conversation

Waldz
Copy link
Member

@Waldz Waldz commented Jan 29, 2020

Fixes:

Building locally github.com/mysteriumnetwork/node/mobile/mysterium...
 gomobile: go build -ldflags  -w -s -X 'github.com/mysteriumnetwork/node/metadata.BuildBranch=master' -X 'github.com/mysteriumnetwork/node/metadata.BuildCommit=0c45ddbd' -X 'github.com/mysteriumnetwork/node/metadata.BuildNumber=113212933' -X 'github.com/mysteriumnetwork/node/metadata.Version=0.20.0-1snapshot-20200129T1044-0c45ddbd'  -buildmode=c-shared -o=/tmp/gomobile-work-694883466/android/src/main/jniLibs/arm64-v8a/libgojni.so gobind failed: exit status 2
 # github.com/mysteriumnetwork/node/cmd
 ../../cmd/di.go:224:32: too many arguments in call to di.bootstrapServices
 	have (node.Options, "github.com/mysteriumnetwork/node/config".ServicesOptions)
 	want (node.Options)
 Error: running "bin/package_android amd64" failed with exit code 1

@codecov-io
Copy link

codecov-io commented Jan 29, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@699663b). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1589   +/-   ##
=========================================
  Coverage          ?   47.42%           
=========================================
  Files             ?      291           
  Lines             ?    11524           
  Branches          ?        0           
=========================================
  Hits              ?     5465           
  Misses            ?     5667           
  Partials          ?      392

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699663b...84889fb. Read the comment docs.

@tadaskay tadaskay merged commit 65f8732 into master Jan 29, 2020
@tadaskay tadaskay deleted the bugfix/fix-android-build branch January 29, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants