Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibility to have just on-demand proposal fetching #1598

Merged
merged 3 commits into from Jan 31, 2020

Conversation

Waldz
Copy link
Member

@Waldz Waldz commented Jan 30, 2020

Needed for mobile

@Waldz Waldz changed the title Possibility to disable have just on-demand proposal fetching Possibility to have just on-demand proposal fetching Jan 31, 2020
@codecov-io
Copy link

Codecov Report

Merging #1598 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1598      +/-   ##
=========================================
- Coverage    47.8%   47.8%   -0.01%     
=========================================
  Files         289     289              
  Lines       11550   11519      -31     
=========================================
- Hits         5522    5507      -15     
+ Misses       5632    5618      -14     
+ Partials      396     394       -2
Impacted Files Coverage Δ
session/pingpong/factory.go 0% <ø> (ø) ⬆️
session/pingpong/invoice_storage.go 93.47% <ø> (+18.85%) ⬆️
session/pingpong/exchange_message_tracker.go 90.21% <100%> (+1.1%) ⬆️
core/promise/methods/noop/dialog_mock.go 68.75% <0%> (-3.13%) ⬇️
core/connection/manager.go 83.22% <0%> (-0.65%) ⬇️
communication/nats/dialog/dialog_waiter.go 88.73% <0%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7507c35...8df2999. Read the comment docs.

@anjmao anjmao merged commit 0c874fa into master Jan 31, 2020
@anjmao anjmao deleted the feature/just-ondemand-proposals branch January 31, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants