Fix WireGuard connection cleanup if start fails #1606
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjmao
requested review from
soffokl,
tadaskay,
vkuznecovas,
Waldz and
zolia
as code owners
vkuznecovas
suggested changes
Jan 31, 2020
anjmao
force-pushed
the
wg-conn-cleanup
branch
3 times, most recently
from
79b7ae8
to
26ba14c
Compare
Codecov Report
@@ Coverage Diff @@
## master #1606 +/- ##
==========================================
+ Coverage 47.78% 48.41% +0.62%
==========================================
Files 288 291 +3
Lines 11478 11650 +172
==========================================
+ Hits 5485 5640 +155
+ Misses 5600 5598 -2
- Partials 393 412 +19
Continue to review full report at Codecov.
|
anjmao
force-pushed
the
wg-conn-cleanup
branch
from
26ba14c
to
c0a98ac
Compare
soffokl
requested changes
Feb 3, 2020
anjmao
force-pushed
the
wg-conn-cleanup
branch
from
c0a98ac
to
b0cc9f5
Compare
Sometimes connection Start could finish setup tunnel but if handshake wait timeout occurs it will not cleanup. Now Start always calls Stop on error which does needed cleanup logic.
anjmao
force-pushed
the
wg-conn-cleanup
branch
from
b0cc9f5
to
b6393fc
Compare
soffokl
approved these changes
Feb 3, 2020
vkuznecovas
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes connection Start could finish setup tunnel but if handshake wait timeout (on any other error) occurs it will not cleanup. Now Start always calls Stop on error which does needed cleanup logic.
Fixes #1499