Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable traffic blocker on Android #1707

Merged
merged 1 commit into from
Feb 13, 2020
Merged

Conversation

anjmao
Copy link
Contributor

@anjmao anjmao commented Feb 13, 2020

Recent firewall refactoring changes broke Android app since on bootstrap in checks for iptables version and uses sudo which fails on Android.

Fixes #1676

@codecov-io
Copy link

Codecov Report

Merging #1707 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1707      +/-   ##
==========================================
- Coverage   48.92%   48.88%   -0.04%     
==========================================
  Files         292      292              
  Lines       11827    11827              
==========================================
- Hits         5786     5782       -4     
- Misses       5617     5620       +3     
- Partials      424      425       +1
Impacted Files Coverage Δ
firewall/factory_linux.go 0% <ø> (ø) ⬆️
core/policy/oracle.go 87.65% <0%> (-4.94%) ⬇️
services/wireguard/connection/connection.go 64.74% <0%> (-2.16%) ⬇️
core/discovery/discovery.go 66.38% <0%> (+0.84%) ⬆️
communication/nats/dialog/dialog_waiter.go 88.73% <0%> (+2.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7fa28fd...69b5323. Read the comment docs.

@vkuznecovas vkuznecovas merged commit c25a6a6 into master Feb 13, 2020
@vkuznecovas vkuznecovas deleted the disable-firewall-on-android branch February 13, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.20.3 mobile doesn't work
5 participants