Simplify connection statistics #1740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjmao
approved these changes
Feb 19, 2020
tadaskay
force-pushed
the
1674-insane-speed-polish
branch
from
d928c3e
to
1a0f2d2
Compare
vkuznecovas
approved these changes
Feb 20, 2020
- Instead of exposing channel, expose a method to simply query stats at any given time. Connection manager starts statistics publisher which reports after given intervals. - Remove stats.interval flags and use a single const connection.StatsReportInterval (2 seconds). - Remove some callback adapters and implement openvpn stats/state event handling on the connection itself.
tadaskay
force-pushed
the
1674-insane-speed-polish
branch
from
db1ca6f
to
5c5b040
Compare
Unify output.
tadaskay
force-pushed
the
1674-insane-speed-polish
branch
from
5c5b040
to
cde2367
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #1674
Connection manager starts statistics publisher which reports after given intervals.