Fix new TTL based NAT hole punching for mobile #1788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soffokl
requested review from
anjmao,
tadaskay,
vkuznecovas,
Waldz and
zolia
as code owners
soffokl
force-pushed
the
fix/mobile-nat-punching
branch
from
1a5b237
to
0a60adb
Compare
Waldz
approved these changes
Feb 27, 2020
soffokl
force-pushed
the
fix/mobile-nat-punching
branch
from
0a60adb
to
3c41758
Compare
zolia
approved these changes
Feb 27, 2020
anjmao
approved these changes
Feb 27, 2020
| @@ -35,6 +34,8 @@ import ( | |||
| "github.com/rs/zerolog/log" | |||
| ) | |||
|
|
|||
| const natPunchingMaxTTL = 10 | |||
There was a problem hiding this comment.
I suggest to change it to more clear name like natPunchingPortsLen etc. In this context TTL is a bit confusing with IP packets TTL.
There was a problem hiding this comment.
The number of ports is needed to test all TTL values up to the natPunchingMaxTTL.
soffokl
force-pushed
the
fix/mobile-nat-punching
branch
from
3c41758
to
348fbde
Compare
Codecov Report
@@ Coverage Diff @@
## master #1788 +/- ##
==========================================
+ Coverage 46.81% 46.82% +<.01%
==========================================
Files 281 281
Lines 11565 11574 +9
==========================================
+ Hits 5414 5419 +5
- Misses 5726 5731 +5
+ Partials 425 424 -1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.