Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unsubscribe from broker on service stop #1794

Merged
merged 1 commit into from Feb 28, 2020

Conversation

soffokl
Copy link
Member

@soffokl soffokl commented Feb 28, 2020

On service restart, we were keeping old subscriptions to the broker.
Closes: #1616

@codecov-io
Copy link

Codecov Report

Merging #1794 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1794      +/-   ##
==========================================
+ Coverage   46.78%   46.79%   +0.01%     
==========================================
  Files         281      281              
  Lines       11574    11575       +1     
==========================================
+ Hits         5415     5417       +2     
+ Misses       5735     5733       -2     
- Partials      424      425       +1
Impacted Files Coverage Δ
communication/nats/dialog/dialog_waiter.go 86.11% <100%> (+0.19%) ⬆️
tequilapi/sse/sse.go 68.88% <0%> (-2.23%) ⬇️
core/discovery/discovery.go 66.38% <0%> (+0.84%) ⬆️
session/pingpong/invoice_payer.go 80.85% <0%> (+1.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4690a7e...3a8470f. Read the comment docs.

@soffokl soffokl merged commit 7295754 into master Feb 28, 2020
@soffokl soffokl deleted the unsubscribe-topic-on-service-stop branch February 28, 2020 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Duplicate dialog create NATS event
4 participants