Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Give more time to start tequilapi #1800

Merged
merged 3 commits into from Feb 28, 2020
Merged

Give more time to start tequilapi #1800

merged 3 commits into from Feb 28, 2020

Conversation

zolia
Copy link
Contributor

@zolia zolia commented Feb 28, 2020

No description provided.

tadaskay
tadaskay requested changes Feb 28, 2020
View reviewed changes
Copy link
Member

@tadaskay tadaskay left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is inherently wrong if node does not start within 5s. 20s is totally wrong.
UPD: as discussed offline, please create a dedicated small machine for running this job to get more consistent results, and adjust the timeout as needed

@zolia zolia force-pushed the do-not-be-greedy-its-not-your-time branch 2 times, most recently from 0e04534 to 646e51d Compare February 28, 2020 16:21
@zolia zolia force-pushed the do-not-be-greedy-its-not-your-time branch from 646e51d to 093c71c Compare February 28, 2020 16:23
@zolia zolia requested a review from tadaskay February 28, 2020 16:24
@codecov-io
Copy link

Codecov Report

Merging #1800 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1800      +/-   ##
==========================================
- Coverage   46.89%   46.86%   -0.04%     
==========================================
  Files         281      281              
  Lines       11576    11576              
==========================================
- Hits         5429     5425       -4     
- Misses       5726     5728       +2     
- Partials      421      423       +2
Impacted Files Coverage Δ
core/policy/oracle.go 86.48% <0%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 334ae73...093c71c. Read the comment docs.

@tadaskay tadaskay merged commit 97442a4 into master Feb 28, 2020
@tadaskay tadaskay deleted the do-not-be-greedy-its-not-your-time branch February 28, 2020 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Waldz Waldz Waldz approved these changes

@tadaskay tadaskay tadaskay approved these changes

@anjmao anjmao Awaiting requested review from anjmao

@soffokl soffokl Awaiting requested review from soffokl soffokl is a code owner

@vkuznecovas vkuznecovas Awaiting requested review from vkuznecovas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zolia @codecov-io @Waldz @tadaskay