Revert "NATS reconnect fully recreates TCP session" #1821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuznecovas
requested review from
anjmao,
soffokl,
tadaskay,
Waldz and
zolia
as code owners
|
Closes #1820 |
|
Looks, like this nats (disconnect fix) really brokes current broker messaging. @Waldz should we revert and wait for p2p communication implementation for direct messaging? |
|
Reopen should:
|
anjmao
approved these changes
Mar 2, 2020
soffokl
approved these changes
Mar 3, 2020
Waldz
force-pushed
the
fix-nats
branch
2 times, most recently
from
ee7ad3b
to
82f0d4b
Compare
soffokl
reviewed
Mar 3, 2020
| @@ -74,3 +74,5 @@ require ( | |||
| gopkg.in/urfave/cli.v1 v1.20.0 // indirect | |||
| gopkg.in/yaml.v2 v2.2.8 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/nats-io/go-nats v1.4.0 => github.com/mysteriumnetwork/nats.go v1.4.1-0.20200303115848-b4a5324c56ed | |||
There was a problem hiding this comment.
Is it really required to have a custom version of nats?
|
This PR was approved as a revert of the commit. But now it merged with completely different changes without review. :/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit c7fbce9.