Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose consumerID in connection/ endpoint #1835

Merged
merged 1 commit into from
Mar 5, 2020
Merged

Expose consumerID in connection/ endpoint #1835

merged 1 commit into from
Mar 5, 2020

Conversation

vkuznecovas
Copy link
Contributor

Closes #1789

@codecov-io
Copy link

Codecov Report

Merging #1835 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1835      +/-   ##
==========================================
+ Coverage   46.77%   46.83%   +0.05%     
==========================================
  Files         284      284              
  Lines       11627    11628       +1     
==========================================
+ Hits         5439     5446       +7     
+ Misses       5765     5762       -3     
+ Partials      423      420       -3
Impacted Files Coverage Δ
tequilapi/client/dto.go 0% <ø> (ø) ⬆️
tequilapi/endpoints/connection.go 88.07% <100%> (+0.11%) ⬆️
core/connection/manager.go 82.83% <100%> (ø) ⬆️
core/connection/status.go 100% <100%> (ø) ⬆️
core/discovery/discovery.go 65.54% <0%> (-0.85%) ⬇️
tequilapi/sse/sse.go 74.44% <0%> (+3.33%) ⬆️
core/policy/oracle.go 91.89% <0%> (+5.4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eaff501...9a14124. Read the comment docs.

@vkuznecovas vkuznecovas merged commit 85e3865 into master Mar 5, 2020
@vkuznecovas vkuznecovas deleted the fix-1789 branch March 5, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Given identity, registry and channelImplementation params have to be hex addresses
4 participants