Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to open multiple connections via NAT hole punching #1887

Merged
merged 4 commits into from
Mar 16, 2020

Conversation

soffokl
Copy link
Member

@soffokl soffokl commented Mar 16, 2020

Closes #1834

nat/traversal/pinger.go Show resolved Hide resolved
nat/traversal/pinger_test.go Outdated Show resolved Hide resolved
nat/traversal/pinger_test.go Show resolved Hide resolved
@soffokl soffokl requested a review from anjmao March 16, 2020 06:37
@codecov-io
Copy link

codecov-io commented Mar 16, 2020

Codecov Report

Merging #1887 into master will increase coverage by 0.05%.
The diff coverage is 66.03%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1887      +/-   ##
==========================================
+ Coverage   47.17%   47.23%   +0.05%     
==========================================
  Files         288      288              
  Lines       11775    11753      -22     
==========================================
- Hits         5555     5551       -4     
+ Misses       5787     5771      -16     
+ Partials      433      431       -2     
Impacted Files Coverage Δ
nat/traversal/noop.go 0.00% <0.00%> (ø)
services/wireguard/service/service_unix.go 16.66% <0.00%> (+0.74%) ⬆️
nat/traversal/pinger.go 75.73% <78.04%> (+2.40%) ⬆️
consumer/bandwidth/tracker.go 100.00% <100.00%> (ø)
session/manager.go 71.87% <100.00%> (ø)
core/discovery/discovery.go 66.38% <0.00%> (+0.84%) ⬆️
core/quality/mysterium_morqa.go 68.85% <0.00%> (+1.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdf0728...fffe1d4. Read the comment docs.

@soffokl soffokl merged commit f15301a into master Mar 16, 2020
@Waldz Waldz deleted the multiple-nat-holes branch March 16, 2020 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare NAT hole punching for communication channel
4 participants