Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate upper bound based on session duration and avg speed #1889

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Calculate upper bound based on session duration and avg speed #1889

merged 2 commits into from
Mar 17, 2020

Conversation

zolia
Copy link
Contributor

@zolia zolia commented Mar 16, 2020

No description provided.

vkuznecovas
vkuznecovas suggested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@vkuznecovas vkuznecovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tests please.

session/pingpong/invoice_payer.go Outdated Show resolved Hide resolved
session/pingpong/invoice_payer.go Outdated Show resolved Hide resolved
@zolia zolia force-pushed the estimate-invoice-tollerance branch 2 times, most recently from f68a336 to c198110 Compare March 16, 2020 16:52
@zolia zolia requested a review from vkuznecovas March 16, 2020 16:53
@zolia zolia force-pushed the estimate-invoice-tollerance branch from c198110 to b1775ca Compare March 17, 2020 07:30
@zolia zolia merged commit 939b53d into master Mar 17, 2020
@zolia zolia deleted the estimate-invoice-tollerance branch March 17, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkuznecovas vkuznecovas vkuznecovas approved these changes

@anjmao anjmao anjmao approved these changes

@soffokl soffokl soffokl approved these changes

@tadaskay tadaskay Awaiting requested review from tadaskay tadaskay is a code owner

@Waldz Waldz Awaiting requested review from Waldz Waldz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zolia @anjmao @soffokl @vkuznecovas