Disable port mapping for routers with a private IP #1890
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soffokl
requested review from
anjmao,
tadaskay,
vkuznecovas,
Waldz and
zolia
as code owners
Codecov Report
@@ Coverage Diff @@
## master #1890 +/- ##
==========================================
+ Coverage 47.16% 47.22% +0.05%
==========================================
Files 288 288
Lines 11790 11804 +14
==========================================
+ Hits 5561 5574 +13
- Misses 5786 5787 +1
Partials 443 443
Continue to review full report at Codecov.
|
anjmao
approved these changes
Mar 17, 2020
Waldz
reviewed
Mar 17, 2020
|
|
||
| log.Debug().Msgf("Detected router public IP address: %s", ip) | ||
|
|
||
| for _, s := range []string{"10.0.0.0/8", "172.16.0.0/12", "192.168.0.0/16"} { |
There was a problem hiding this comment.
Maybe better to validate against IP oracle external IP instead of hardcoding these values. Some exotic private networks might be skipped here
There was a problem hiding this comment.
There are no exotic private networks. Only these are considered by numeration standards. Everything else is either reserved for such things as multicasting or should be considered public.
zolia
approved these changes
Mar 17, 2020
soffokl
force-pushed
the
disable-portmapping-for-private-routers
branch
from
82d195d
to
c23d6ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1850