Allow for R recovery #1904
Merged
Allow for R recovery #1904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuznecovas
requested review from
anjmao,
soffokl,
tadaskay,
Waldz and
zolia
as code owners
|
The required changes are already live on accountant and are backwards compatible. |
Waldz
reviewed
Mar 23, 2020
vkuznecovas
force-pushed
the
r-recovery
branch
2 times, most recently
from
253de11
to
7e25ea5
Compare
anjmao
approved these changes
Mar 24, 2020
vkuznecovas
force-pushed
the
r-recovery
branch
3 times, most recently
from
272faf1
to
0e01c88
Compare
zolia
approved these changes
Mar 24, 2020
soffokl
approved these changes
Mar 25, 2020
tadaskay
approved these changes
Mar 25, 2020
The provider will now send an encrypted R to the accountant so that he can store it. Once there, the encrypted R will be sent back to us if a missmatch occurs. Upon receiving such an error, a provider will decrypt the R and send it back to accountant.
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
==========================================
+ Coverage 47.52% 47.59% +0.06%
==========================================
Files 287 287
Lines 12043 12103 +60
==========================================
+ Hits 5724 5760 +36
- Misses 5843 5865 +22
- Partials 476 478 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The provider will now send an encrypted R to the accountant so that he can store it.
Once there, the encrypted R will be sent back to us if a missmatch occurs.
Upon receiving such an error, a provider will decrypt the R and send it back to accountant.
closes #1585