Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use same DTOs for tequilapi server and client (identity) #1906

Merged
merged 5 commits into from
Mar 24, 2020

Conversation

tadaskay
Copy link
Member

The same model will also be used in SSE.

Ref: #1844

@codecov-io
Copy link

Codecov Report

Merging #1906 into master will decrease coverage by 0.03%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1906      +/-   ##
==========================================
- Coverage   47.48%   47.45%   -0.04%     
==========================================
  Files         287      287              
  Lines       11992    11945      -47     
==========================================
- Hits         5695     5668      -27     
+ Misses       5832     5816      -16     
+ Partials      465      461       -4     
Impacted Files Coverage Δ
tequilapi/client/client.go 7.35% <0.00%> (+0.28%) ⬆️
tequilapi/client/dto.go 0.00% <ø> (ø)
tequilapi/endpoints/identities.go 36.60% <88.88%> (-11.02%) ⬇️
nat/traversal/pinger.go 75.73% <0.00%> (-1.48%) ⬇️
core/policy/oracle.go 91.89% <0.00%> (+5.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ca03e23...9a7727c. Read the comment docs.

tequilapi/contract/identity.go Outdated Show resolved Hide resolved
tequilapi/contract/identity.go Outdated Show resolved Hide resolved
@tadaskay tadaskay merged commit e7787ae into master Mar 24, 2020
@tadaskay tadaskay deleted the 1844-consumer-state-api branch March 24, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants