Expose earnings balance to Tequilapi #1913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Waldz
requested review from
chompomonim,
ignasbernotas,
anjmao,
tadaskay,
soffokl,
zolia and
vkuznecovas
Waldz
force-pushed
the
feature/expose-provider-earnings
branch
2 times, most recently
from
13f5607
to
206f474
Compare
Codecov Report
@@ Coverage Diff @@
## master #1913 +/- ##
==========================================
- Coverage 47.51% 47.41% -0.10%
==========================================
Files 287 286 -1
Lines 11972 11974 +2
==========================================
- Hits 5689 5678 -11
- Misses 5818 5830 +12
- Partials 465 466 +1
Continue to review full report at Codecov.
|
soffokl
approved these changes
Mar 25, 2020
vkuznecovas
approved these changes
Mar 25, 2020
| @@ -107,6 +107,8 @@ func (c *cliApp) getIdentity(actionArgs []string) { | |||
| info("Channel address:", identityStatus.ChannelAddress) | |||
| info("Balance:", identityStatus.Balance) | |||
| info("Balance estimate:", identityStatus.BalanceEstimate) | |||
| info("Earnings:", identityStatus.Earnings) | |||
There was a problem hiding this comment.
end users will be confused by the earnings and earnings total.
There was a problem hiding this comment.
I would suggest a better name but can't think of any.
There was a problem hiding this comment.
Source #1731.
ATM can't think off anything better :/
tadaskay
requested changes
Mar 25, 2020
Waldz
force-pushed
the
feature/expose-provider-earnings
branch
2 times, most recently
from
69e2642
to
3701a7d
Compare
tadaskay
approved these changes
Mar 25, 2020
Waldz
force-pushed
the
feature/expose-provider-earnings
branch
from
3701a7d
to
622c2c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates: #1731
Tequilapi now haves lifetime earnings and unsettled earnings fields next to identity.
Also E2E to test for simple value transfer from consumer balance to provider earnings.