Increate base tolerance due to MTU mismatch #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolia
requested review from
anjmao,
soffokl,
tadaskay,
vkuznecovas and
Waldz
as code owners
Waldz
approved these changes
Mar 25, 2020
zolia
force-pushed
the
increase-fragemntation-tolerance
branch
2 times, most recently
from
10562f6
to
69df654
Compare
tadaskay
approved these changes
Mar 25, 2020
soffokl
approved these changes
Mar 25, 2020
vkuznecovas
approved these changes
Mar 25, 2020
zolia
force-pushed
the
increase-fragemntation-tolerance
branch
from
69df654
to
4109d96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing revealed that avg MTU for packet on macos is by 64 bytes smaller, most likely resulting in excessive fragmentation in comparison with linux based wg implementation. Testing on linux did not reveal increase in tolerance required. But it is safe to assume that provider that alter they MTU to smaller size will require higher tolerance.