Expose identity earnings to SSE state #1916
Conversation
Waldz
requested review from
ignasbernotas,
anjmao,
tadaskay,
soffokl,
zolia and
vkuznecovas
Waldz
force-pushed
the
feature/expose-provider-earnings
branch
4 times, most recently
from
b9bb8b7
to
028757d
Compare
| } | ||
|
|
||
| // GetBalance returns a pre-defined balance. | ||
| func (mbp *mockBalanceProvider) GetBalance(_ identity.Identity) uint64 { |
There was a problem hiding this comment.
This is identical to mocks.BalanceProvider
There was a problem hiding this comment.
I moved mocks next to tests, because keeping them global packages causes circular dependencies: pingpong -> mocks -> connections -> pingpong
There was a problem hiding this comment.
There is no dependency on connections in the mocks package. Either way, mocks should have minimal dependencies.
There was a problem hiding this comment.
I added similar mock EarningsProvider.SettlementState(_ identity.Identity) pingpong.SettlementState and mocks package starts to be interdependent.
Lets agree on having mocks next to package we're testing.
There was a problem hiding this comment.
Such widely used types as identity.Identity or in this case pingpong.SettlementState could be in a leaf package with minimal dependencies - that will solve the package cycle. If it's a one-off mock - then it's good to have it next to the test. If it's used multiple times, then the maintenance becomes a burden and it should be in mocks.
Waldz
force-pushed
the
feature/expose-provider-earnings
branch
2 times, most recently
from
b3f26f1
to
ffeb620
Compare
Waldz
force-pushed
the
feature/expose-provider-earnings
branch
from
ffeb620
to
59f21cc
Compare
Updates: #1731
Web UI now can interactively show increasing earnings