Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Establish p2p channel via broker #1922

Merged
merged 7 commits into from
Mar 27, 2020
Merged

Establish p2p channel via broker #1922

merged 7 commits into from
Mar 27, 2020

Conversation

anjmao
Copy link
Contributor

@anjmao anjmao commented Mar 26, 2020

  1. Key and config exchange for p2p via broker.
  2. Migrated p2p messages to protobuf.
  3. P2P channel rewritten with raw kcp library UDP session.

Consumer will not use p2p channel yet, so old flow should work as is, but I want to review and merge it as we are getting merge conflicts.

TODO for next PRs:

  1. Pass service type to channel creation so it can work for multiple services (Provider side).
  2. Enable p2p channel on consumer side.
  3. Pass second punched UDP conn to services (Consumer side).
  4. Add internal message send retry.

localnet/provider.sh Outdated Show resolved Hide resolved
core/service/subscription.go Outdated Show resolved Hide resolved
core/service/subscription.go Outdated Show resolved Hide resolved
@codecov-io
Copy link

codecov-io commented Mar 26, 2020

Codecov Report

Merging #1922 into master will increase coverage by 0.56%.
The diff coverage is 51.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1922      +/-   ##
==========================================
+ Coverage   47.48%   48.05%   +0.56%     
==========================================
  Files         286      287       +1     
  Lines       12108    12595     +487     
==========================================
+ Hits         5750     6053     +303     
- Misses       5878     5985     +107     
- Partials      480      557      +77     
Impacted Files Coverage Δ
core/connection/stats.go 70.00% <ø> (ø)
core/service/subscription.go 0.00% <0.00%> (ø)
nat/traversal/noop.go 0.00% <0.00%> (ø)
services/wireguard/connection/connection.go 58.95% <0.00%> (-2.12%) ⬇️
session/dto.go 42.85% <0.00%> (-17.15%) ⬇️
session/pingpong/exchange_messaging.go 0.00% <0.00%> (ø)
session/pingpong/factory.go 0.00% <0.00%> (ø)
session/pingpong/invoice_messaging.go 0.00% <0.00%> (ø)
tequilapi/client/dto.go 0.00% <ø> (ø)
tequilapi/endpoints/connection_location.go 85.36% <ø> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e416f3b...1e2b471. Read the comment docs.

session/dto.go Outdated Show resolved Hide resolved
p2p/message.go Outdated Show resolved Hide resolved
p2p/message.go Outdated Show resolved Hide resolved
p2p/manager.go Outdated Show resolved Hide resolved
p2p/manager.go Outdated Show resolved Hide resolved
p2p/manager.go Outdated Show resolved Hide resolved
core/connection/manager.go Outdated Show resolved Hide resolved
core/service/manager.go Outdated Show resolved Hide resolved
p2p/manager.go Outdated Show resolved Hide resolved
p2p/manager.go Outdated Show resolved Hide resolved
session/pingpong/exchange_messaging.go Outdated Show resolved Hide resolved
session/pingpong/factory.go Show resolved Hide resolved
session/pingpong/factory.go Show resolved Hide resolved
p2p/channel.go Outdated Show resolved Hide resolved
p2p/channel.go Outdated Show resolved Hide resolved
p2p/channel.go Outdated Show resolved Hide resolved
p2p/channel.go Show resolved Hide resolved
p2p/channel.go Outdated Show resolved Hide resolved
p2p/channel.go Outdated Show resolved Hide resolved
@anjmao anjmao force-pushed the p2p-dialog-create branch 4 times, most recently from df56cd7 to 553c5c1 Compare March 26, 2020 16:18
@anjmao anjmao merged commit 0edf288 into master Mar 27, 2020
@anjmao anjmao deleted the p2p-dialog-create branch March 27, 2020 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants