-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Establish p2p channel via broker #1922
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjmao
commented
Mar 26, 2020
soffokl
reviewed
Mar 26, 2020
Codecov Report
@@ Coverage Diff @@
## master #1922 +/- ##
==========================================
+ Coverage 47.48% 48.05% +0.56%
==========================================
Files 286 287 +1
Lines 12108 12595 +487
==========================================
+ Hits 5750 6053 +303
- Misses 5878 5985 +107
- Partials 480 557 +77
Continue to review full report at Codecov.
|
vkuznecovas
suggested changes
Mar 26, 2020
zolia
suggested changes
Mar 26, 2020
zolia
suggested changes
Mar 26, 2020
df56cd7
to
553c5c1
Compare
553c5c1
to
1e2b471
Compare
soffokl
approved these changes
Mar 27, 2020
vkuznecovas
approved these changes
Mar 27, 2020
1e2b471
to
19eb11a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consumer will not use p2p channel yet, so old flow should work as is, but I want to review and merge it as we are getting merge conflicts.
TODO for next PRs: