Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add back ping peer implementation to not break backwards compatibility #1924

Merged
merged 1 commit into from
Mar 26, 2020

Conversation

anjmao
Copy link
Contributor

@anjmao anjmao commented Mar 26, 2020

  1. Methods PingPeer and PingConsumer cannot use pinger with new changes since it requires peer to send ping ack and old nodes doesn't support that.
  2. There are some issues on @soffokl network, which seems to be related to latency, need to test that.

@anjmao anjmao merged commit d32ad9e into master Mar 26, 2020
@anjmao anjmao deleted the add-old-pinger branch March 26, 2020 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants