-
Notifications
You must be signed in to change notification settings - Fork 311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify balance further #1936
Merged
Merged
Simplify balance further #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkuznecovas
requested review from
anjmao,
soffokl,
tadaskay,
Waldz and
zolia
as code owners
March 27, 2020 09:08
tadaskay
approved these changes
Mar 27, 2020
vkuznecovas
force-pushed
the
further-balance-simplification
branch
2 times, most recently
from
March 27, 2020 09:30
d119e30
to
92aa677
Compare
anjmao
suggested changes
Mar 27, 2020
Waldz
reviewed
Mar 27, 2020
Waldz
reviewed
Mar 27, 2020
Waldz
reviewed
Mar 27, 2020
Waldz
reviewed
Mar 27, 2020
Waldz
requested changes
Mar 27, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decouple store at all
After discussions, decided to add a struct wrapping the calculations, as well as emitting a single grand total change event for simplicity.
vkuznecovas
force-pushed
the
further-balance-simplification
branch
from
March 27, 2020 12:01
92aa677
to
5ce5d59
Compare
anjmao
approved these changes
Mar 27, 2020
Waldz
approved these changes
Mar 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussions, decided to add a struct wrapping the calculations,
as well as emitting a single grand total change event for simplicity.