Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nil check for connection ack #1947

Merged
merged 1 commit into from
Mar 30, 2020
Merged

Add nil check for connection ack #1947

merged 1 commit into from
Mar 30, 2020

Conversation

vkuznecovas
Copy link
Contributor

Fixes #1943

@codecov-io
Copy link

Codecov Report

Merging #1947 into master will increase coverage by 0.11%.
The diff coverage is 61.18%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1947      +/-   ##
==========================================
+ Coverage   47.98%   48.10%   +0.11%     
==========================================
  Files         287      289       +2     
  Lines       12617    12640      +23     
==========================================
+ Hits         6054     6080      +26     
+ Misses       5998     5995       -3     
  Partials      565      565              
Impacted Files Coverage Δ
core/service/subscription.go 0.00% <0.00%> (ø)
session/pingpong/exchange_messaging.go 0.00% <0.00%> (ø)
session/pingpong/factory.go 0.00% <0.00%> (ø)
session/pingpong/invoice_messaging.go 0.00% <0.00%> (ø)
core/service/manager.go 58.53% <50.00%> (ø)
p2p/listener.go 60.44% <60.44%> (ø)
p2p/dialer.go 61.22% <61.22%> (ø)
p2p/common.go 64.91% <64.91%> (ø)
p2p/channel.go 76.19% <76.92%> (-1.37%) ⬇️
core/connection/manager.go 71.95% <80.00%> (+0.22%) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3afd14...b30b414. Read the comment docs.

@vkuznecovas vkuznecovas merged commit f2ef3d4 into master Mar 30, 2020
@vkuznecovas vkuznecovas deleted the fix-1943 branch March 30, 2020 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consumer daemon dies with fatal exit
5 participants