Add p2p sent messages logging #1970
Conversation
anjmao
requested review from
soffokl,
tadaskay,
vkuznecovas,
Waldz and
zolia
as code owners
| res, err := p2pChannel.Send(p2p.TopicSessionCreate, sessionRequest) | ||
| } | ||
| log.Info().Msgf("Sending P2P message to %q: %s", p2p.TopicSessionCreate, sessionRequest.String()) | ||
| res, err := p2pChannel.Send(p2p.TopicSessionCreate, p2p.ProtoMessage(sessionRequest)) |
There was a problem hiding this comment.
Please do logging inside p2pChannel.Send(), will be hard to remember to add this liners before each sending or receiving.
Also code will be less noisy.
There was a problem hiding this comment.
Send message accepts this struct
type Message struct {
Data []byte
}It is not coupled to concrete message struct, you just send bytes. If I add it to Send I can't log formatted payload with fields. There are only 5 places there it is needed right now and we will not have much more of these messages.
Also, what if you want to add more context to logging? I suggest to keep it explicit as is.
There was a problem hiding this comment.
Well serialisation should happen in transport level also ;)
There was a problem hiding this comment.
p2p transport layer works with raw bytes, there is no need to for extra abstractions.
Some more logging for p2p messages.