Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Protect p2p from vpn tunnel on mobile #1986

Merged
merged 9 commits into from
Apr 1, 2020
Merged

Protect p2p from vpn tunnel on mobile #1986

merged 9 commits into from
Apr 1, 2020

Conversation

anjmao
Copy link
Contributor

@anjmao anjmao commented Apr 1, 2020 •
edited

Fixes #1985

Also:

  1. Fixes data race for broker proposals unit tests. (I hope)
  2. Some small refactorings, removed textproto conn wrapper.

zolia
zolia approved these changes Apr 1, 2020
View reviewed changes
core/connection/connect_options.go Outdated Show resolved Hide resolved
core/connection/manager_test.go Outdated Show resolved Hide resolved
p2p/channel.go Outdated Show resolved Hide resolved
p2p/channel.go Outdated Show resolved Hide resolved
@anjmao anjmao requested review from zolia and soffokl April 1, 2020 15:47
@anjmao anjmao merged commit 2653ca9 into master Apr 1, 2020
@anjmao anjmao deleted the protect-p2p-from-vpn branch April 1, 2020 19:01
This was referenced Apr 1, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zolia zolia zolia approved these changes

@tadaskay tadaskay Awaiting requested review from tadaskay tadaskay is a code owner

@vkuznecovas vkuznecovas Awaiting requested review from vkuznecovas

@Waldz Waldz Awaiting requested review from Waldz Waldz is a code owner

@soffokl soffokl Awaiting requested review from soffokl soffokl is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

P2P: Exlude p2p from VPN tunnel on mobile
3 participants
@anjmao @soffokl @zolia