Make iptables path consistent across dists #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zolia
requested review from
anjmao,
soffokl,
tadaskay,
vkuznecovas and
Waldz
as code owners
zolia
changed the title
tadaskay
approved these changes
May 20, 2020
zolia
force-pushed
the
bugfix/fix-iptables-path
branch
3 times, most recently
from
a169031
to
1fe4ca5
Compare
tadaskay
approved these changes
May 20, 2020
zolia
force-pushed
the
bugfix/fix-iptables-path
branch
from
1fe4ca5
to
8edf16c
Compare
Codecov Report
@@ Coverage Diff @@
## master #2266 +/- ##
==========================================
- Coverage 48.01% 47.96% -0.05%
==========================================
Files 273 273
Lines 12757 12757
==========================================
- Hits 6125 6119 -6
- Misses 6044 6047 +3
- Partials 588 591 +3
Continue to review full report at Codecov.
|
zolia
force-pushed
the
bugfix/fix-iptables-path
branch
from
8edf16c
to
0e388a4
Compare
soffokl
reviewed
May 21, 2020
zolia
force-pushed
the
bugfix/fix-iptables-path
branch
from
0e388a4
to
8b1a0e1
Compare
soffokl
approved these changes
May 21, 2020
zolia
force-pushed
the
bugfix/fix-iptables-path
branch
from
8b1a0e1
to
745e6c3
Compare
zolia
force-pushed
the
bugfix/fix-iptables-path
branch
from
828ef6b
to
9cd7bf6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #2146 and #2241
/usr/sbin/iptables is a preferred way according recent distributions. Ensuring that this path exist.