Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access services in state test via public methods #2276

Merged
merged 1 commit into from
May 22, 2020
Merged

Conversation

vkuznecovas
Copy link
Contributor

This ensures that no races occur as all public API is behind a lock.

Fixes #2197

@codecov-commenter
Copy link

codecov-commenter commented May 21, 2020

Codecov Report

Merging #2276 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2276      +/-   ##
==========================================
+ Coverage   47.87%   47.89%   +0.02%     
==========================================
  Files         273      273              
  Lines       12767    12767              
==========================================
+ Hits         6112     6115       +3     
+ Misses       6065     6061       -4     
- Partials      590      591       +1     
Impacted Files Coverage Δ
nat/traversal/pinger.go 72.33% <0.00%> (-1.95%) ⬇️
core/connection/manager.go 82.36% <0.00%> (+0.46%) ⬆️
session/pingpong/invoice_tracker.go 67.86% <0.00%> (+0.65%) ⬆️
tequilapi/endpoints/sse_handler.go 74.78% <0.00%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e63f92...42b148c. Read the comment docs.

This ensures that no races occur as all public API is behind a lock.

Fixes #2197
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test: Data race state Keeper
4 participants