Win supervisor #2278
Merged
Win supervisor #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
anjmao
commented
May 21, 2020
anjmao
commented
- Add Windows supervisor service.
- Add Windows WireGuard tunnel. (Will need some changes in separate PR)
- Move common network utils to separate package to reuse for all platforms.
- Refactor myst process kill to be cross platform.
- No need to pass myst user for myst process startup as it now will be started from the app.
anjmao
requested review from
soffokl,
tadaskay,
vkuznecovas,
Waldz and
zolia
as code owners
soffokl
approved these changes
May 22, 2020
anjmao
commented
May 22, 2020
zolia
suggested changes
May 22, 2020
| if err != nil { | ||
| return fmt.Errorf("could not kill process %d: %w", proc.Pid, err) | ||
| } | ||
| state, err := proc.Wait() |
There was a problem hiding this comment.
we probably should not wait forever here..
There was a problem hiding this comment.
There is no way to provide context or timeout to proc.Wait, kill is running in separate goroutine so it will not block the whole supervisor communaction.
anjmao
force-pushed
the
win-supervisor
branch
2 times, most recently
from
6d7542a
to
b655d93
Compare
Codecov Report
@@ Coverage Diff @@
## master #2278 +/- ##
==========================================
- Coverage 47.93% 47.88% -0.05%
==========================================
Files 273 275 +2
Lines 12770 12790 +20
==========================================
+ Hits 6121 6125 +4
- Misses 6062 6077 +15
- Partials 587 588 +1
Continue to review full report at Codecov.
|
zolia
approved these changes
May 25, 2020
| } | ||
|
|
||
| func (c Config) valid() bool { | ||
| return c.MystPath != "" && c.OpenVPNPath != "" | ||
| return true |
There was a problem hiding this comment.
looks like not needed method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.