Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear stale consumer sessions on new connect #2285

Merged
merged 3 commits into from
May 27, 2020

Conversation

soffokl
Copy link
Member

@soffokl soffokl commented May 26, 2020

Closes: #2176

@codecov-commenter
Copy link

codecov-commenter commented May 26, 2020

Codecov Report

Merging #2285 into master will increase coverage by 0.02%.
The diff coverage is 85.71%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2285      +/-   ##
==========================================
+ Coverage   47.89%   47.91%   +0.02%     
==========================================
  Files         275      275              
  Lines       12797    12810      +13     
==========================================
+ Hits         6129     6138       +9     
- Misses       6079     6083       +4     
  Partials      589      589              
Impacted Files Coverage Δ
session/event_based_storage.go 75.00% <0.00%> (-3.27%) ⬇️
session/manager.go 60.86% <93.33%> (+7.02%) ⬆️
session/storage_memory.go 89.65% <100.00%> (+1.72%) ⬆️
tequilapi/endpoints/sse_handler.go 72.17% <0.00%> (-2.61%) ⬇️
p2p/channel.go 74.32% <0.00%> (-2.30%) ⬇️
core/discovery/discovery.go 64.75% <0.00%> (-0.82%) ⬇️
nat/traversal/pinger.go 74.27% <0.00%> (+1.94%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1c632b1...29e2b96. Read the comment docs.

session/manager.go Show resolved Hide resolved
session/manager.go Outdated Show resolved Hide resolved
Copy link
Contributor

@vkuznecovas vkuznecovas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we have a test please?

session/manager.go Outdated Show resolved Hide resolved
@soffokl soffokl force-pushed the clear-stale-consumer-session-on-connect branch from 2bda0d0 to f1c5517 Compare May 27, 2020 00:41
@soffokl soffokl force-pushed the clear-stale-consumer-session-on-connect branch from f1c5517 to 29e2b96 Compare May 27, 2020 00:44
@soffokl soffokl requested review from Waldz and vkuznecovas May 27, 2020 00:47
@soffokl soffokl merged commit de028e0 into master May 27, 2020
@soffokl soffokl deleted the clear-stale-consumer-session-on-connect branch May 27, 2020 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow only one active session from consumer
5 participants