Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force settle if balance exhausted #2306

Merged
merged 1 commit into from Jun 2, 2020

Conversation

vkuznecovas
Copy link
Contributor

Fixes issues where those who had issues settling in the first place are not settling now.

@codecov-commenter
Copy link

Codecov Report

Merging #2306 into master will decrease coverage by 0.03%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2306      +/-   ##
==========================================
- Coverage   48.09%   48.06%   -0.04%     
==========================================
  Files         276      276              
  Lines       12874    12890      +16     
==========================================
+ Hits         6192     6195       +3     
- Misses       6086     6097      +11     
- Partials      596      598       +2     
Impacted Files Coverage Δ
session/pingpong/accountant_promise_settler.go 44.75% <0.00%> (-1.13%) ⬇️
session/pingpong/invoice_tracker.go 65.50% <0.00%> (-2.58%) ⬇️
core/policy/oracle.go 86.48% <0.00%> (-5.41%) ⬇️
nat/traversal/pinger.go 74.27% <0.00%> (ø)
p2p/channel.go 76.62% <0.00%> (+2.29%) ⬆️
tequilapi/endpoints/sse_handler.go 74.78% <0.00%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5bdc55...db0df7f. Read the comment docs.

@vkuznecovas vkuznecovas force-pushed the force-settle-on-balance-exhaust branch from db0df7f to 371ebe2 Compare June 1, 2020 07:36
@vkuznecovas vkuznecovas force-pushed the force-settle-on-balance-exhaust branch from 371ebe2 to c6ded12 Compare June 1, 2020 09:15
@vkuznecovas vkuznecovas merged commit aa40348 into master Jun 2, 2020
@vkuznecovas vkuznecovas deleted the force-settle-on-balance-exhaust branch June 2, 2020 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants