Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Windows WireGuard DNS support #2344

Merged
merged 2 commits into from Jun 8, 2020
Merged

Add Windows WireGuard DNS support #2344

merged 2 commits into from Jun 8, 2020

Conversation

anjmao
Copy link
Contributor

@anjmao anjmao commented Jun 8, 2020

This PR adds support for setting DNS on Windows. Since on Windows to set DNS admin permissions are needed setting DNS also moved to supervisor when running in usermode.

Closes #1840

services/wireguard/connection/dns/dns_windows.go Outdated Show resolved Hide resolved
core/connection/dns_option.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2020

Codecov Report

Merging #2344 into master will increase coverage by 0.22%.
The diff coverage is 47.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2344      +/-   ##
==========================================
+ Coverage   48.05%   48.27%   +0.22%     
==========================================
  Files         280      280              
  Lines       12978    13069      +91     
==========================================
+ Hits         6236     6309      +73     
- Misses       6144     6153       +9     
- Partials      598      607       +9     
Impacted Files Coverage Δ
core/connection/dns_option.go 48.97% <0.00%> (+3.69%) ⬆️
services/wireguard/endpoint/userspace/client.go 0.00% <0.00%> (ø)
services/wireguard/service/service_unix.go 21.33% <0.00%> (-0.89%) ⬇️
services/wireguard/connection/connection.go 69.69% <85.71%> (+3.03%) ⬆️
services/wireguard/wgcfg/device_config.go 87.23% <100.00%> (ø)
core/policy/oracle.go 86.48% <0.00%> (-5.41%) ⬇️
session/pingpong/consumer_balance_tracker.go 66.66% <0.00%> (-2.23%) ⬇️
nat/traversal/pinger.go 72.33% <0.00%> (-1.95%) ⬇️
tequilapi/endpoints/sse_handler.go 74.78% <0.00%> (+2.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27eb43f...4245ec4. Read the comment docs.

@anjmao anjmao merged commit bb34c87 into master Jun 8, 2020
@anjmao anjmao deleted the win-dns branch June 8, 2020 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provider DNS support for Windows and WireGuard
5 participants