Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supervisor standalone win #2381

Merged
merged 3 commits into from Jun 11, 2020
Merged

Supervisor standalone win #2381

merged 3 commits into from Jun 11, 2020

Conversation

tadaskay
Copy link
Member

@tadaskay tadaskay commented Jun 11, 2020

Add support for running supervisor NOT as a windows service

Useful for development to run it as a standalone exe.
When installed, supervisor will be passed `-winservice` (false by default) trigger the service flow.
@codecov-commenter
Copy link

Codecov Report

Merging #2381 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2381      +/-   ##
==========================================
- Coverage   48.31%   48.29%   -0.02%     
==========================================
  Files         280      280              
  Lines       13073    13073              
==========================================
- Hits         6316     6314       -2     
  Misses       6154     6154              
- Partials      603      605       +2     
Impacted Files Coverage Δ
nat/traversal/pinger.go 72.33% <0.00%> (-1.95%) ⬇️
p2p/channel.go 75.09% <0.00%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9922fac...e7f46bc. Read the comment docs.

@tadaskay tadaskay merged commit 50dff13 into master Jun 11, 2020
@tadaskay tadaskay deleted the supervisor-standalone-win branch June 11, 2020 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants