Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/MYST-596 DNS update for windows #278

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
4 participants
@tadovas
Copy link
Member

commented Jul 3, 2018

No description provided.

@tadovas tadovas requested review from interro, Waldz and zolia Jul 3, 2018

@tadovas tadovas requested a review from donce as a code owner Jul 3, 2018


import "github.com/mysterium/node/openvpn/config"

func defaultClientConfig(runtimeDir string, scriptSearchPath string) *ClientConfig {

This comment has been minimized.

Copy link
@Waldz

Waldz Jul 3, 2018

Member

Would be nice to leave this function in openvpn/client_config.go to make Git history more searchable

This comment has been minimized.

Copy link
@tadovas

tadovas Jul 3, 2018

Author Member

Good point 👍

@tadovas tadovas dismissed stale reviews from Waldz and interro via 81f199c Jul 3, 2018

@tadovas tadovas force-pushed the feature/MYST-596-dns-updates-on-windows branch from 0ed800d to 81f199c Jul 3, 2018

@zolia

zolia approved these changes Jul 3, 2018

@Waldz

Waldz approved these changes Jul 3, 2018

@tadovas tadovas merged commit 31fc985 into master Jul 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@tadovas tadovas deleted the feature/MYST-596-dns-updates-on-windows branch Jul 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.