Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/MYST-596 DNS update for windows #278

Merged
merged 1 commit into from Jul 3, 2018

Conversation

tadovas
Copy link
Contributor

@tadovas tadovas commented Jul 3, 2018

No description provided.

@tadovas tadovas requested review from interro, Waldz and zolia July 3, 2018 12:35
@tadovas tadovas requested a review from donce as a code owner July 3, 2018 12:35
interro
interro previously approved these changes Jul 3, 2018
Waldz
Waldz previously approved these changes Jul 3, 2018

import "github.com/mysterium/node/openvpn/config"

func defaultClientConfig(runtimeDir string, scriptSearchPath string) *ClientConfig {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to leave this function in openvpn/client_config.go to make Git history more searchable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point 👍

@tadovas tadovas dismissed stale reviews from Waldz and interro via 81f199c July 3, 2018 13:05
@tadovas tadovas force-pushed the feature/MYST-596-dns-updates-on-windows branch from 0ed800d to 81f199c Compare July 3, 2018 13:05
@tadovas tadovas merged commit 31fc985 into master Jul 3, 2018
@tadovas tadovas deleted the feature/MYST-596-dns-updates-on-windows branch July 3, 2018 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants