Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump payments and s3 lib #3348

Merged
merged 2 commits into from
May 5, 2021
Merged

Bump payments and s3 lib #3348

merged 2 commits into from
May 5, 2021

Conversation

tomasmik
Copy link
Contributor

@tomasmik tomasmik commented Apr 30, 2021

Bumped payments to latest possible version: https://github.com/mysteriumnetwork/payments/tree/bump-eth-v1.10.2

After bumping we were also forced to bump the aws lib version (because new go-ethereum version also uses it). The build seems to still be working:

...
Running target: PackageLinuxRaspberryImage
2021-04-30T13:14:46.085 INF ci/packages/raspberry.go:170             > Looking up Raspbian image file
2021-04-30T13:14:46.154 INF ci/storage/s3.go:137                     > Cached copy not found: 2021-01-11-raspbian-buster-lite.zip
2021-04-30T13:14:46.154 INF ci/storage/s3.go:144                     > downloading file from the bucket
2021-04-30T13:14:48.028 INF ci/storage/s3.go:160                     > Downloaded file: 2021-01-11-raspbian-buster-lite.zip (439MB)
2021-04-30T13:14:48.028 INF ci/packages/raspberry.go:181             > Extracting raspbian image to: 2021-01-11-raspbian-buster-lite
2021-04-30T13:15:04.181 ??? github.com/rs/zerolog@v1.17.2/log.go:403 > exec: sudo apt-get update
...

Full build step is here: https://gitlab.com/mysteriumnetwork/node/-/jobs/1226407402


numBytes, err := downloader.Download(file, &s3.GetObjectInput{
numBytes, err := downloader.Download(context.TODO(), file, &s3.GetObjectInput{
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we now have context here, we could add a timeout, though I was not sure what is the amount of time we can wait for the file download, so I just added TODO(). If anyone thinks it's worth to timeout here, you're free to make suggestions.

@tomasmik tomasmik requested a review from alvatar May 4, 2021 06:37
@tomasmik tomasmik merged commit f69dfc9 into master May 5, 2021
@tomasmik tomasmik deleted the bump-payments-ethv branch May 5, 2021 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants