Beneficiary change CLI improvements #3350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasmik
force-pushed
the
beneficiary-change
branch
3 times, most recently
from
637fc9c
to
289befc
Compare
tomasmik
force-pushed
the
beneficiary-change
branch
from
289befc
to
e565d47
Compare
Codecov Report
@@ Coverage Diff @@
## master #3350 +/- ##
==========================================
- Coverage 43.67% 43.62% -0.05%
==========================================
Files 320 320
Lines 14032 14032
==========================================
- Hits 6129 6122 -7
- Misses 7181 7187 +6
- Partials 722 723 +1
Continue to review full report at Codecov.
|
mdomasevicius
approved these changes
May 4, 2021
vkuznecovas
approved these changes
May 4, 2021
mdomasevicius
approved these changes
May 4, 2021
* CLI now relies on status keeper to track beneficiary change * Status keeper now cleans any pending statuses once requested so that apps like web-ui dont block * Before if you submited the request to change your beneficiary and exited from node the request would hang forever. Not it's cleaned up the next time you try to get it if the beneficiary actually changed.
tomasmik
force-pushed
the
beneficiary-change
branch
from
0a47c6b
to
8edf246
Compare
tomasmik
force-pushed
the
beneficiary-change
branch
from
1f363d3
to
8a2d89b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #3344
Closes: #3300