Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node proposal fixes #3429

Merged
merged 4 commits into from
May 26, 2021
Merged

Node proposal fixes #3429

merged 4 commits into from
May 26, 2021

Conversation

tadaskay
Copy link
Member

@tadaskay tadaskay commented May 25, 2021

Fixes: #3426 (node and discovery is using ip_type, but location oracle is still returning node_type)
Fixes: proposal price not matching service start opts (way off)

No idea why those multiplication by accuracy were needed in the first place.
@codecov-commenter
Copy link

Codecov Report

Merging #3429 (0e9249d) into master (32b8548) will increase coverage by 0.03%.
The diff coverage is 53.84%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3429      +/-   ##
==========================================
+ Coverage   43.24%   43.28%   +0.03%     
==========================================
  Files         312      312              
  Lines       13790    13789       -1     
==========================================
+ Hits         5964     5969       +5     
+ Misses       7103     7098       -5     
+ Partials      723      722       -1     
Impacted Files Coverage Δ
core/location/oracle_resolver.go 0.00% <0.00%> (ø)
session/pingpong/factory.go 0.00% <ø> (ø)
market/price.go 46.15% <83.33%> (-16.35%) ⬇️
core/service/manager.go 68.96% <100.00%> (+2.71%) ⬆️
market/service_proposal.go 66.66% <100.00%> (ø)
tequilapi/endpoints/service.go 90.83% <100.00%> (ø)
nat/traversal/pinger.go 72.13% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32b8548...0e9249d. Read the comment docs.

@tadaskay tadaskay merged commit 6efb833 into master May 26, 2021
@tadaskay tadaskay deleted the node-fixxes branch May 26, 2021 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

node_type is N/A in rc3
5 participants