Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set custom bandwidth limit #3431

Merged
merged 1 commit into from
May 26, 2021
Merged

Conversation

soffokl
Copy link
Member

@soffokl soffokl commented May 26, 2021

Closes #3401

@codecov-commenter
Copy link

Codecov Report

Merging #3431 (eb65370) into master (4ad6e75) will increase coverage by 0.02%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3431      +/-   ##
==========================================
+ Coverage   43.34%   43.36%   +0.02%     
==========================================
  Files         312      312              
  Lines       13788    13790       +2     
==========================================
+ Hits         5976     5980       +4     
- Misses       7089     7090       +1     
+ Partials      723      720       -3     
Impacted Files Coverage Δ
config/flags_node.go 10.09% <0.00%> (-0.19%) ⬇️
requests/dialer_swarm.go 73.68% <0.00%> (-4.39%) ⬇️
tequilapi/endpoints/sse_handler.go 66.95% <0.00%> (-2.61%) ⬇️
p2p/channel.go 73.83% <0.00%> (+0.84%) ⬆️
nat/traversal/pinger.go 76.50% <0.00%> (+5.46%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4ad6e75...eb65370. Read the comment docs.

Copy link
Contributor

@Zensey Zensey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good

@soffokl soffokl merged commit 32b8548 into master May 26, 2021
@soffokl soffokl deleted the configurable-bandwidth-limit branch May 26, 2021 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make bandwidth limit configurable
5 participants