Attempt to avoid ghost sessions in NodeUI #4053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdomasevicius
requested review from
Snawoot,
soffokl,
tadaskay,
tomasmik,
vkuznecovas,
Waldz and
zolia
as code owners
vkuznecovas
approved these changes
Oct 6, 2021
Codecov Report
@@ Coverage Diff @@
## master #4053 +/- ##
==========================================
- Coverage 43.29% 43.16% -0.14%
==========================================
Files 331 331
Lines 17625 17625
==========================================
- Hits 7630 7607 -23
- Misses 9235 9247 +12
- Partials 760 771 +11
Continue to review full report at Codecov.
|
soffokl
approved these changes
Oct 7, 2021
We have been getting some bug reports that SSE state that we push contain long-running sessions with 0 traffic. It is possible that Session `Created` and `Removed` could be fired almost the same time but due to `SubscribeAsync` will arrive in reverse order that permanently adding a session to pushed SSE state which in turn will display a ghost session in NodeUI that is not sending/receiving traffic. Signed-off-by: Mantas Domaševičius <mantas@mysterium.network>
mdomasevicius
force-pushed
the
fixes/ghost-sessions
branch
from
a023ae9
to
8c3ba57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been getting some bug reports that SSE state push contains long-running sessions with 0 traffic. It is possible that Session
CreatedandRemovedcould be fired almost the same time but due toSubscribeAsyncwill arrive in reverse order permanently adding a session to pushed SSE state which in turn will display a ghost session in NodeUI that is not sending/receiving traffic.Signed-off-by: Mantas Domaševičius mantas@mysterium.network