Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signed broker topics #4063

Merged
merged 6 commits into from
Oct 11, 2021
Merged

Signed broker topics #4063

merged 6 commits into from
Oct 11, 2021

Conversation

Snawoot
Copy link
Contributor

@Snawoot Snawoot commented Oct 8, 2021

Closes https://github.com/mysteriumnetwork/infra/issues/63

node containing these changes should be released only after nats-proxy will be deployed.

@codecov-commenter
Copy link

Codecov Report

Merging #4063 (b5e7b04) into master (c822f9d) will decrease coverage by 2.14%.
The diff coverage is 52.54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4063      +/-   ##
==========================================
- Coverage   42.91%   40.76%   -2.15%     
==========================================
  Files         332      333       +1     
  Lines       17679    17708      +29     
==========================================
- Hits         7587     7219     -368     
- Misses       9324     9798     +474     
+ Partials      768      691      -77     
Impacted Files Coverage Δ
communication/nats/signed.go 0.00% <0.00%> (ø)
p2p/listener.go 0.00% <0.00%> (-62.33%) ⬇️
communication/nats/sender.go 52.38% <55.55%> (-4.38%) ⬇️
communication/nats/receiver.go 38.04% <58.33%> (-1.04%) ⬇️
core/discovery/brokerdiscovery/messaging_ping.go 100.00% <100.00%> (ø)
...re/discovery/brokerdiscovery/messaging_register.go 100.00% <100.00%> (ø)
.../discovery/brokerdiscovery/messaging_unregister.go 63.63% <100.00%> (-36.37%) ⬇️
core/discovery/brokerdiscovery/registry.go 100.00% <100.00%> (ø)
p2p/net_default.go 0.00% <0.00%> (-100.00%) ⬇️
p2p/common.go 0.00% <0.00%> (-66.67%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c822f9d...b5e7b04. Read the comment docs.

@Snawoot Snawoot merged commit 8aeb999 into master Oct 11, 2021
@Snawoot Snawoot deleted the signed_broker_topics branch October 11, 2021 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants