Enable real forwarding for wireguard service #596
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tadovas
suggested changes
Dec 6, 2018
| @@ -99,6 +117,10 @@ func (ce *connectionEndpoint) Stop() error { | |||
| return err | |||
| } | |||
|
|
|||
| if ce.natService != nil { | |||
There was a problem hiding this comment.
can it be nil ? its depedency
There was a problem hiding this comment.
connectionEndpoint is used both for provider and consumer.
There is no reason to do anything with NAT for the consumer.
So the answer is yes, it can be nil for the consumer.
There was a problem hiding this comment.
That means that connection endpoint is too low level component to handle forwarding. Behaviour based on ifs is not a very good practice
There was a problem hiding this comment.
Moved NAT configuration to the service manager.
tadovas
suggested changes
Dec 6, 2018
| @@ -68,6 +63,29 @@ func (ce *connectionEndpoint) Start(config *wg.ServiceConfig) error { | |||
| ce.privateKey = config.Consumer.PrivateKey | |||
| } | |||
|
|
|||
| if ce.ipResolver != nil { | |||
There was a problem hiding this comment.
This shows too much details - could be separate private function with clear name
soffokl
force-pushed
the
wireguard-forwarding
branch
from
b73e31c
to
bc31f4a
Compare
zolia
previously approved these changes
Dec 6, 2018
soffokl
force-pushed
the
wireguard-forwarding
branch
from
bc31f4a
to
ccdd3f6
Compare
|
Fixed tests and rebased it. Please take a look again. |
tadovas
approved these changes
Dec 6, 2018
|
@zolia @vkuznecovas lets decide |
zolia
approved these changes
Dec 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.