Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Max/add model schema #22

Merged
merged 4 commits into from
Jan 11, 2022
Merged

Max/add model schema #22

merged 4 commits into from
Jan 11, 2022

Conversation

bjornaer
Copy link
Contributor

No description provided.

@bjornaer bjornaer self-assigned this Jan 11, 2022
@paulcjh
Copy link
Member

paulcjh commented Jan 11, 2022

Model schemas look good.
Only issue I see here is with adding models as "Runnables". Only pipelines & functions should be "runnable" and then the model is referenced from either. It is not "Run" itself. Check out this HF example I made: https://github.com/mystic-ai/pipeline/blob/main/examples/hf_model.py

@bjornaer bjornaer requested a review from paulcjh January 11, 2022 13:12
@bjornaer bjornaer marked this pull request as ready for review January 11, 2022 13:45
paulcjh
paulcjh approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@paulcjh paulcjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@paulcjh
Copy link
Member

paulcjh commented Jan 11, 2022

I saw your comment on the FunctionGet, I think this is something Alex left. Will circle back, I think it's okay to delete but will double check.

@alexpearce
Copy link
Contributor

I think this is something Alex left. Will circle back, I think it's okay to delete but will double check.

I think so too. The schemas in function are sufficient.

@bjornaer bjornaer merged commit 4e87224 into main Jan 11, 2022
@bjornaer bjornaer deleted the max/add-model-schema branch January 11, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulcjh paulcjh paulcjh approved these changes

@alexpearce alexpearce Awaiting requested review from alexpearce

Assignees

@bjornaer bjornaer

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bjornaer @paulcjh @alexpearce