Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add schemas for runnable metrics endpoints #41

Merged
merged 2 commits into from
Feb 11, 2022
Merged

Add schemas for runnable metrics endpoints #41

merged 2 commits into from
Feb 11, 2022

Conversation

andrei-trandafir
Copy link
Contributor

No description provided.

@andrei-trandafir andrei-trandafir requested review from a team, bjornaer, paulcjh and alexpearce and removed request for a team February 11, 2022 11:35
alexpearce
alexpearce previously approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@alexpearce alexpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for this. A bit of documentation on each schema would be nice but I won't insist.

paulcjh
paulcjh previously approved these changes Feb 11, 2022
View reviewed changes
@andrei-trandafir andrei-trandafir enabled auto-merge (squash) February 11, 2022 15:38
alexpearce
alexpearce approved these changes Feb 11, 2022
View reviewed changes
Copy link
Contributor

@alexpearce alexpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the docs! Looks good to me.

Only thing we could improve on is mentioning that some metrics, e.g. averages, are undefined when run_count is zero.

@andrei-trandafir andrei-trandafir merged commit 1f079a2 into main Feb 11, 2022
@andrei-trandafir andrei-trandafir deleted the na-364-metrics branch February 11, 2022 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpearce alexpearce alexpearce approved these changes

@paulcjh paulcjh paulcjh left review comments

@bjornaer bjornaer Awaiting requested review from bjornaer bjornaer was automatically assigned from mystic-ai/backend

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrei-trandafir @alexpearce @paulcjh