Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docker module test change #43

Merged
merged 5 commits into from
Feb 14, 2022
Merged

docker module test change #43

merged 5 commits into from
Feb 14, 2022

Conversation

bjornaer
Copy link
Contributor

@bjornaer bjornaer commented Feb 11, 2022 •
edited
Loading

make test autoclean created files

enable arbitrary directory to be provided for docker api functionality

fixed pattern in codeowners file

renamed run_local to just run

@bjornaer bjornaer self-assigned this Feb 11, 2022
alexpearce
alexpearce previously approved these changes Feb 14, 2022
View reviewed changes
Copy link
Contributor

@alexpearce alexpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Only a couple of suggestions from me but am happy for you to ignore them.

pipeline/docker/__init__.py Show resolved Hide resolved
tests/test_docker.py Outdated Show resolved Hide resolved
@bjornaer bjornaer merged commit bc122a9 into main Feb 14, 2022
@bjornaer bjornaer deleted the max/fix-docker-test branch February 14, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexpearce alexpearce alexpearce approved these changes

@paulcjh paulcjh Awaiting requested review from paulcjh

Assignees

@bjornaer bjornaer

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjornaer @alexpearce