-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scaling config yaml #454
Scaling config yaml #454
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only question I have is whether scaling_config
represents a scaling config ID or name? If it's just one or the other, maybe it's worth naming it scaling_config_id
or scaling_config_name
so that it's obvious to people adding it to their YAML? Or if we're gonna support both then should be fine to leave as is
Its a name, I've copied the convention we used in the pipeline patch, but agree its slightly confusing. |
ok, I guess we'll have to document this somewhere anyway, so we can make sure we specify that it needs to be the name and not the ID |
Just changed it anyway lol, for the api calls and models themselves we can stick to this convention but the config having name just makes it clearer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Allow submitting a scaling config name alongside pipeline create.