Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Use link to tagged version for rule docs #11

Merged
merged 1 commit into from
Jan 21, 2018

Conversation

sudo-suhas
Copy link
Contributor

This adds a utility function and uses the version present in package.json for generating the URL to tagged version of the rule documentation. I think this is good because the documentation will match the version the user has installed. This way, even if a rule is changed or removed in the future, the user can find the documentation with ease.

@mysticatea
Copy link
Owner

Thank you for contributing!

Would you fix CI failing?

@codecov-io
Copy link

codecov-io commented Jan 21, 2018

Codecov Report

Merging #11 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   98.66%   98.68%   +0.01%     
==========================================
  Files          18       18              
  Lines         225      228       +3     
==========================================
+ Hits          222      225       +3     
  Misses          3        3
Impacted Files Coverage Δ
lib/rules/no-restricted-disable.js 100% <ø> (ø) ⬆️
lib/rules/disable-enable-pair.js 100% <ø> (ø) ⬆️
lib/rules/no-unused-disable.js 100% <ø> (ø) ⬆️
lib/rules/no-duplicate-disable.js 100% <ø> (ø) ⬆️
lib/rules/no-unused-enable.js 100% <ø> (ø) ⬆️
lib/rules/no-aggregating-enable.js 100% <ø> (ø) ⬆️
lib/rules/no-unlimited-disable.js 91.66% <ø> (ø) ⬆️
lib/rules/no-use.js 92.3% <ø> (ø) ⬆️
lib/utils.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20cf1a4...ccb2620. Read the comment docs.

@mysticatea
Copy link
Owner

Thank you!

@mysticatea mysticatea merged commit ce320f7 into mysticatea:master Jan 21, 2018
@sudo-suhas
Copy link
Contributor Author

Would you fix CI failing?

My sincere apologies for this. Should have checked CI after making PR.

Thank you!

My pleasure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants