Skip to content

Commit

Permalink
Fix: improve the message of no-deprecated-api for Buffer
Browse files Browse the repository at this point in the history
  • Loading branch information
@mysticatea
mysticatea committed Oct 13, 2016
1 parent d849588 commit d8142a1
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 17 deletions.
2 changes: 1 addition & 1 deletion lib/util/deprecated-apis.js
View file
Expand Up @@ -17,7 +17,7 @@ module.exports = {
$constructor: {
$deprecated: true,
since: 6,
replacedBy: "'buffer.Buffer.alloc()' or 'buffer.Buffer.from()'",
replacedBy: "'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0')",
omittableNew: true,
},
},
Expand Down
32 changes: 16 additions & 16 deletions tests/lib/rules/no-deprecated-api.js
View file
Expand Up @@ -77,60 +77,60 @@ ruleTester.run("no-deprecated-api", rule, {
{
code: "new (require('buffer').Buffer)()",
env: {node: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "require('buffer').Buffer()",
env: {node: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "var b = require('buffer'); new b.Buffer()",
env: {node: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "var b = require('buffer'); new b['Buffer']()",
env: {node: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "var b = require('buffer'); new b[`Buffer`]()",
env: {node: true, es6: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "var b = require('buffer').Buffer; new b()",
env: {node: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "var b; new ((b = require('buffer')).Buffer)(); new b.Buffer()",
env: {node: true},
errors: [
"'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead.",
"'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead.",
"'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead.",
"'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead.",
],
},
{
code: "var {Buffer: b} = require('buffer'); new b()",
env: {node: true, es6: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "var {['Buffer']: b = null} = require('buffer'); new b()",
env: {node: true, es6: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "var {'Buffer': b = null} = require('buffer'); new b()",
env: {node: true, es6: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "var {Buffer: b = require('buffer').Buffer} = {}; new b()",
env: {node: true, es6: true},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "require('buffer').SlowBuffer",
Expand Down Expand Up @@ -319,25 +319,25 @@ ruleTester.run("no-deprecated-api", rule, {
code: "import b from 'buffer'; new b.Buffer()",
env: {es6: true},
parserOptions: {sourceType: "module"},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "import * as b from 'buffer'; new b.Buffer()",
env: {es6: true},
parserOptions: {sourceType: "module"},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "import * as b from 'buffer'; new b.default.Buffer()",
env: {es6: true},
parserOptions: {sourceType: "module"},
errors: ["'buffer.default.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.default.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "import {Buffer as b} from 'buffer'; new b()",
env: {es6: true},
parserOptions: {sourceType: "module"},
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' instead."],
errors: ["'buffer.Buffer' constructor was deprecated since v6. Use 'buffer.Buffer.alloc()' or 'buffer.Buffer.from()' (use 'safe-buffer' module for '<6.0.0') instead."],
},
{
code: "import b from 'buffer'; b.SlowBuffer",
Expand Down

0 comments on commit d8142a1

Please sign in to comment.