Fix: relax allowModules option (fixes #35)

mysticatea · May 13, 2016 · f59bfba · f59bfba
1 parent 789e4dd
commit f59bfba
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 4 deletions.
diff --git a/lib/rules/no-missing-import.js b/lib/rules/no-missing-import.js
@@ -42,7 +42,7 @@ module.exports.schema = [
                 type: "array",
                 items: {
                     type: "string",
-                    pattern: "^(?:@[a-zA-Z0-9_]+/)?[a-zA-Z0-9_]+$"
+                    pattern: "^(?:@[a-zA-Z0-9_\\-.]+/)?[a-zA-Z0-9_\\-.]+$"
                 },
                 uniqueItems: true
             },

diff --git a/lib/rules/no-missing-require.js b/lib/rules/no-missing-require.js
@@ -42,7 +42,7 @@ module.exports.schema = [
                 type: "array",
                 items: {
                     type: "string",
-                    pattern: "^(?:@[a-zA-Z0-9_]+/)?[a-zA-Z0-9_]+$"
+                    pattern: "^(?:@[a-zA-Z0-9_\\-.]+/)?[a-zA-Z0-9_\\-.]+$"
                 },
                 uniqueItems: true
             },

diff --git a/lib/rules/no-unpublished-import.js b/lib/rules/no-unpublished-import.js
@@ -42,7 +42,7 @@ module.exports.schema = [
                 type: "array",
                 items: {
                     type: "string",
-                    pattern: "^(?:@[a-zA-Z0-9_]+/)?[a-zA-Z0-9_]+$"
+                    pattern: "^(?:@[a-zA-Z0-9_\\-.]+/)?[a-zA-Z0-9_\\-.]+$"
                 },
                 uniqueItems: true
             },

diff --git a/lib/rules/no-unpublished-require.js b/lib/rules/no-unpublished-require.js
@@ -42,7 +42,7 @@ module.exports.schema = [
                 type: "array",
                 items: {
                     type: "string",
-                    pattern: "^(?:@[a-zA-Z0-9_]+/)?[a-zA-Z0-9_]+$"
+                    pattern: "^(?:@[a-zA-Z0-9_\\-.]+/)?[a-zA-Z0-9_\\-.]+$"
                 },
                 uniqueItems: true
             },

diff --git a/tests/lib/rules/no-missing-require.js b/tests/lib/rules/no-missing-require.js
@@ -194,6 +194,12 @@ ruleTester.run("no-missing-require", rule, {
             code: "require('electron');",
             options: [{allowModules: ["electron"]}],
             env: {node: true}
+        },
+        {
+            filename: fixture("test.js"),
+            code: "require('jquery.cookie');",
+            options: [{allowModules: ["jquery.cookie"]}],
+            env: {node: true}
         }
     ],
     invalid: [