Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read required Node.js version from project package.json #29

Closed
sindresorhus opened this issue Apr 19, 2016 · 3 comments
Closed

Read required Node.js version from project package.json #29

sindresorhus opened this issue Apr 19, 2016 · 3 comments
Assignees
@mysticatea
Labels
accepted enhancement

Comments

@sindresorhus
Copy link

For the no-unsupported-features rule. I have a shareable config and I don't want to manually specify the required Node.js version for each project. That information is already available in the engines field in package.json.

You could use read-pkg-up.
@mysticatea
Copy link
Owner

Thank you for this issue.

It's a good idea!
I will make the rule reading that information by default.

@mysticatea mysticatea self-assigned this Apr 19, 2016
@sindresorhus sindresorhus mentioned this issue Apr 24, 2016
Closed
@mysticatea
Copy link
Owner

Hmm, semver seems to not provide API to get the minimum version of semver ranges. @sindresorhus Do you have any idea?

@mysticatea
Copy link
Owner

mysticatea commented Apr 27, 2016 •
edited
Loading

Oh, I got it.

image

mysticatea added a commit that referenced this issue Apr 27, 2016
@mysticatea
Update: no-unsupported-features gets reading engines of `package.…
8311a81 
…json` (fixes #29)

This depends on undocumented APIs of `semver` module. So I pinned the
version of `semver`.
@mysticatea mysticatea mentioned this issue Apr 27, 2016
Merged
mysticatea added a commit that referenced this issue Apr 27, 2016
@mysticatea
Update: no-unsupported-features gets reading engines of `package.…
90fce67 
…json` (fixes #29) (#34)

This depends on undocumented APIs of `semver` module. So I pinned the
version of `semver`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mysticatea mysticatea

Labels
accepted enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sindresorhus @mysticatea