Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add URL to rule documentation to the metadata #102

Merged
merged 1 commit into from
Jan 8, 2018

Conversation

Arcanemagus
Copy link
Contributor

ESLint v4.15.0 added an official location for rules to store a URL to their documentation in the rule metadata in eslint/eslint#9788. This adds the URL to all the existing rules so anything consuming them can
know where their documentation is without having to resort to external packages to guess.

ESLint v4.15.0 added an official location for rules to store a URL to
their documentation in the rule metadata in eslint/eslint#9788. This
adds the URL to all the existing rules so anything consuming them can
know where their documentation is without having to resort to external
packages to guess.
@codecov-io
Copy link

codecov-io commented Jan 8, 2018

Codecov Report

Merging #102 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #102   +/-   ##
=======================================
  Coverage   98.52%   98.52%           
=======================================
  Files          42       42           
  Lines        1014     1014           
=======================================
  Hits          999      999           
  Misses         15       15
Impacted Files Coverage Δ
lib/rules/no-extraneous-import.js 90.9% <ø> (ø) ⬆️
lib/rules/no-extraneous-require.js 90.9% <ø> (ø) ⬆️
lib/rules/no-unpublished-require.js 100% <ø> (ø) ⬆️
lib/rules/no-deprecated-api.js 100% <ø> (ø) ⬆️
lib/rules/exports-style.js 98.27% <ø> (ø) ⬆️
lib/rules/no-unsupported-features.js 98.96% <ø> (ø) ⬆️
lib/rules/no-missing-require.js 100% <ø> (ø) ⬆️
lib/rules/no-unpublished-import.js 100% <ø> (ø) ⬆️
lib/rules/process-exit-as-throw.js 95% <ø> (ø) ⬆️
lib/rules/no-unpublished-bin.js 92.59% <ø> (ø) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 846e677...c593e0f. Read the comment docs.

Copy link
Owner

@mysticatea mysticatea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants