Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Bump bootstrap from 3.4.1 to 4.1.2 #1634

Closed

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 29, 2019

Bumps bootstrap from 3.4.1 to 4.1.2. This update includes security fixes.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Moderate severity vulnerability that affects bootstrap
In Bootstrap before 4.1.2, XSS is possible in the data-target property of scrollspy. This is similar to CVE-2018-14042.

Affected versions: < 4.1.2

Release notes

Sourced from bootstrap's releases.

v4.1.2

  • Fixed an XSS vulnerability in tooltip, collapse, and scrollspy plugins
  • Improved how we query elements in our JavaScript plugins
  • Inline SVGs now have the same vertical alignment as images
  • Fixed issues with double transitions on carousels
  • Added Edge and IE10-11 fallbacks to our floating labels example
  • Various improvements to form controls, including disabled states on file inputs and unified focus styles for selects

Checkout the v4.1.2 ship list and GitHub project for the full details.

v4.1.1

Our first patch release for Bootstrap 4! Here's a quick rundown of some of the changes:

  • Added validation styles for file inputs
  • Improved printing of dark tables
  • Suppressed that text-hide deprecation notice by default
  • Cleaned up some JS globals and improve coverage
  • Bumped dependencies, namely Jekyll
  • Fixed docs issue with incorrect name for our monospace font utility

Checkout the v4.1.1 ship list and GitHub project for the full details.

v4.1.0

  • Added new custom range form control.
  • Added new .carousel-fade modifier to switch carousel from horizontal sliding to crossfade.
  • Added new .dropdown-item-text for plaintext dropdown items.
  • Added new .flex-fill, .flex-grow-*, and .flex-shrink-* utilities.
  • Added new .table-borderless variant for tables.
  • Added new .text-monospace utility.
  • Added new .text-body (default body color), .text-black-50 (50% opacity black), and .text-white-50 (50% opacity white) utilities.
  • Added new .shadow-* utilities for quickly adding box-shadows.
  • Added ability to disable Popper's positioning in dropdowns.
  • Fixed longstanding issue with Chrome incorrectly rendering cards across CSS columns.
  • Deprecated .text-hide—you'll see a warning during compilation—as it's a dated and undocumented feature.
  • Fixed up Dashboard and Offcanvas examples across Firefox and IE.
  • Breadcrumbs can now use non-string values as dividers.
  • Updated our Theming docs to confirm you cannot use CSS variables in media queries (sorry folks!).

Be sure to look at the ship list and project board for more details on all our fixes.

v4.0.0

Our first stable v4 release! 🎉

Highlights:

  • Brand new examples and overhauls for existing ones.
  • Additional border utilities have been added and the default border-color for them darkened from $gray-200 to $gray-300.
  • Pagination focus styles now match button and input focus state.
  • Added responsive .order-0 classes to reset column order.
  • Improved examples of form validation documentation by adding tooltip examples and more.
  • New documentation added for using our CSS variables to the Theming page.
... (truncated)
Commits
  • 1f46337 Update README.md
  • c4ccfbe Ship v4.1.2
  • a49f5ca Clean up npm scripts a bit more.
  • 6589408 Update scripts.
  • de7bef8 update card columns docs to make copy more accurate
  • 5a11ba5 clarify docs dev and add 4.0 link
  • aedd700 change dist to only affect main since docs css isn't distributed
  • 4518288 Move copy tasks back to css-main and js-compile so docs-github task runs prop...
  • 159aebc Update watch scripts to properly copy JS files
  • 01f568d fixes #26637
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Note: This repo was added to Dependabot recently, so you'll receive a maximum of 5 PRs for your first few update runs. Once an update run creates fewer than 5 PRs we'll remove that limit.

You can always request more updates by clicking Bump now in your Dependabot dashboard.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot ignore this [patch|minor|major] version will close this PR and stop Dependabot creating any more for this minor/major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Pull request limits (per update run and/or open at any time)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

Finally, you can contact us by mentioning @dependabot.

@jameswettenhall
Copy link
Contributor

According to twbs/bootstrap#26627 (comment), Bootstrap v3.3.7 is not affected. Does that mean v3.4.1 is not affected? Even if v3.4.1 is affected, MyTardis doesn't use scrollspy.

@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.1.2 branch from 140f688 to d5c7ba6 Compare May 28, 2019 11:39
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.1.2 branch 4 times, most recently from 945fbd6 to f0c23b7 Compare June 27, 2019 09:50
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.1.2 branch from f0c23b7 to 518302e Compare July 23, 2019 07:07
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.1.2 branch 3 times, most recently from 633111b to ca8178c Compare August 7, 2019 06:46
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.1.2 branch 2 times, most recently from 0e37b35 to 9978629 Compare September 26, 2019 02:14
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.1.2 branch 3 times, most recently from 26f00e1 to 0d93466 Compare October 8, 2019 06:30
Bumps [bootstrap](https://github.com/twbs/bootstrap) from 3.4.1 to 4.1.2. **This update includes security fixes.**
- [Release notes](https://github.com/twbs/bootstrap/releases)
- [Commits](twbs/bootstrap@v3.4.1...v4.1.2)

Signed-off-by: dependabot[bot] <support@dependabot.com>
@dependabot-preview dependabot-preview bot force-pushed the dependabot/npm_and_yarn/bootstrap-4.1.2 branch from 0d93466 to 1a8aec3 Compare October 8, 2019 22:08
@dependabot-preview
Copy link
Contributor Author

Superseded by #2156.

@dependabot-preview dependabot-preview bot deleted the dependabot/npm_and_yarn/bootstrap-4.1.2 branch December 3, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant